Include "flatmap" in docs of Option::and_then #22111
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
| @@ -605,6 +605,8 @@ impl<T> Option<T> { | |||
| /// Returns `None` if the option is `None`, otherwise calls `f` with the | |||
| /// wrapped value and returns the result. | |||
| /// | |||
| /// Other languages call this operation "flatmap". | |||
There was a problem hiding this comment.
period goes inside the quotes.
There was a problem hiding this comment.
Oh, I guess that's US style. I'd rather remove the quotes in that case. Are you ok with that?
|
One small nit, and also, maybe "Some languages" rather than "other languages." But thanks! r=me after |
Some newcomers might look for a "flatMap" method on Option. Include the reference so that searching the page would find "and_then".
robinst
force-pushed
the
option-docs-flatmap
branch
from
c83a835 to
dab626b
Compare
|
@robinst oh! I didn't see you updated this, sorry. |
…eklabnik Some newcomers might look for a "flatMap" method on Option. Include the reference so that searching the page would find "and_then".
Some newcomers might look for a "flatMap" method on Option. Include the
reference so that searching the page would find "and_then".