rustc: Fix a number of stability lint holes #22127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @aturon |
alexcrichton
force-pushed
the
stability-holes
branch
from
4ded3bc
to
9bc0d47
Compare
| @@ -1119,8 +1119,7 @@ impl<'a, T: ?Sized> DerefMut for &'a mut T { | |||
|
|
|||
| /// A version of the call operator that takes an immutable receiver. | |||
| #[lang="fn"] | |||
| #[unstable(feature = "core", | |||
| reason = "uncertain about variadic generics, input versus associated types")] | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
There was a problem hiding this comment.
Uhoh. These are supposed to stay unstable, and only be usable via the -> sugar.
|
Nice! @alexcrichton answered my questions on IRC. @bors: r+ 9bc0d47 |
alexcrichton
force-pushed
the
stability-holes
branch
from
9bc0d47
to
bbbb571
Compare
There are a number of holes that the stability lint did not previously cover,
including:
* Types
* Bounds on type parameters on functions and impls
* Where clauses
* Imports
* Patterns (structs and enums)
These holes have all been fixed by overriding the `visit_path` function on the
AST visitor instead of a few specialized cases. This change also necessitated a
few stability changes:
* The `collections::fmt` module is now stable (it was already supposed to be).
* The `thread_local::imp::Key` type is now stable (it was already supposed to
be).
* The `std::rt::{begin_unwind, begin_unwind_fmt}` functions are now stable.
These are required via the `panic!` macro.
* The `std::old_io::stdio::{println, println_args}` functions are now stable.
These are required by the `print!` and `println!` macros.
* The `ops::{FnOnce, FnMut, Fn}` traits are now `#[stable]`. This is required to
make bounds with these traits stable. Note that manual implementations of
these traits are still gated by default, this stability only allows bounds
such as `F: FnOnce()`.
Additionally, the compiler now has special logic to ignore its own generated
`__test` module for the `--test` harness in terms of stability.
Closes rust-lang#8962
Closes rust-lang#16360
Closes rust-lang#20327
[breaking-change]
|
⌛ Testing commit bbbb571 with merge 9d02ab1... |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 11, 2015
There are a number of holes that the stability lint did not previously cover,
including:
* Types
* Bounds on type parameters on functions and impls
* Where clauses
* Imports
* Patterns (structs and enums)
These holes have all been fixed by overriding the `visit_path` function on the
AST visitor instead of a few specialized cases. This change also necessitated a
few stability changes:
* The `collections::fmt` module is now stable (it was already supposed to be).
* The `thread_local::imp::Key` type is now stable (it was already supposed to
be).
* The `std::rt::{begin_unwind, begin_unwind_fmt}` functions are now stable.
These are required via the `panic!` macro.
* The `std::old_io::stdio::{println, println_args}` functions are now stable.
These are required by the `print!` and `println!` macros.
* The `ops::{FnOnce, FnMut, Fn}` traits are now `#[stable]`. This is required to
make bounds with these traits stable. Note that manual implementations of
these traits are still gated by default, this stability only allows bounds
such as `F: FnOnce()`.
Closes rust-lang#8962
Closes rust-lang#16360
Closes rust-lang#20327
|
💔 Test failed - auto-win-64-opt |
|
@bors: retry |
|
⌛ Testing commit bbbb571 with merge 7fd79f4... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry |
|
Amazing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of holes that the stability lint did not previously cover,
including:
These holes have all been fixed by overriding the
visit_pathfunction on theAST visitor instead of a few specialized cases. This change also necessitated a
few stability changes:
collections::fmtmodule is now stable (it was already supposed to be).thread_local::imp::Keytype is now stable (it was already supposed tobe).
std::rt::{begin_unwind, begin_unwind_fmt}functions are now stable.These are required via the
panic!macro.std::old_io::stdio::{println, println_args}functions are now stable.These are required by the
print!andprintln!macros.ops::{FnOnce, FnMut, Fn}traits are now#[stable]. This is required tomake bounds with these traits stable. Note that manual implementations of
these traits are still gated by default, this stability only allows bounds
such as
F: FnOnce().Closes #8962
Closes #16360
Closes #20327