implement missing iterator traits for slice::Windows #22166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dcrewi
commented
Feb 11, 2015
dcrewi
commented
- DoubleEndedIterator
- ExactSizeIterator
- RandomAccessIterator
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| } | ||
|
|
||
| #[stable(feature = "rust1", since = "1.0.0")] | ||
| impl<'a, T> ExactSizeIterator for Windows<'a, T> {} |
There was a problem hiding this comment.
This looks like it may not actually be able to be implemented due to this line in size_hint:
(x.saturating_add(1), x.checked_add(1))If x were uint::MAX then this would return (uint::MAX, None), breaking the contract of ExactSizeIterator. The value of x, however is self.v.len() - self.size and we know that size != 0 so we're guaranteed that the checked_add will always return Some.
Could you update the above size_hint to return (x + 1, Some(x + 1)) to be clear that it is a precise size?
- DoubleEndedIterator - ExactSizeIterator - RandomAccessIterator
dcrewi
force-pushed
the
iter-impls-for-windows
branch
from
d6cc1ee to
cf475e6
Compare
|
Changes force-pushed. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 11, 2015
- DoubleEndedIterator - ExactSizeIterator - RandomAccessIterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.