Skip to content

Link from literals to their encoding #22270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

steveklabnik
Copy link
Member

Fixes #22152

@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw
Copy link
Member

huonw commented Feb 13, 2015

I don't quite understand what is meant by "encoding" here.

@steveklabnik
Copy link
Member Author

That they are IEEE 754-2008 floats, specifically. As opposed to some other representation.

@steveklabnik
Copy link
Member Author

@huonw ping? does that make sense?

@huonw
Copy link
Member

huonw commented Feb 19, 2015

That they are IEEE 754-2008 floats, specifically. As opposed to some other representation.

Hm, I think I prefer that as a word; "encoding" feels a bit too much like e.g. encoding to/from json. Thoughts? (If you agree, r=me with "representation" instead.)

@steveklabnik
Copy link
Member Author

@bors: r=huonw d7c02c3

@steveklabnik
Copy link
Member Author

@huonw agreed, and done. Thanks!

@steveklabnik
Copy link
Member Author

@bors: rollup

bombless added a commit to bombless/rust that referenced this pull request Feb 23, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 23, 2015
@alexcrichton alexcrichton merged commit d7c02c3 into rust-lang:master Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document float encoding in reference
4 participants