-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rename fmt::Writer
to fmt::Write
#22311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This brings it in line with its namesake in `std::io`. [breaking-change]
Sorry for the slow review, was away for the weekend. This looks great to me! Just want to check in with @alexcrichton before I send it to bors. |
Hm I do agree that I would personally be ok just calling this |
I agree, that guideline is intentionally a loose recommendation not a hard rule. |
Do you think it's worth going through a deprecation phase for this, or should we just rename as this PR is doing? |
I think a rename is fine, I don't think this is a widely used trait at all (unlike |
@alexcrichton I suspect the reason why I don't really have an opinion on this though. |
Hm, so we may eventually provide a Unicode-only "textwriter" in IO, and I suppose the name might want to match that -- but I guarantee it won't be called |
This brings it in line with its namesake in `std::io`. [breaking-change] r? @aturon
This brings it in line with its namesake in `std::io`. [breaking-change] r? @aturon
This brings it in line with its namesake in
std::io
.[breaking-change]
r? @aturon