temporary hack to make testing std::time reliable #2259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was getting more than just failed tests, I was occasionally getting crashes as well. It seems like setenv on mac is not just unthreadsafe, it seems to be thread hostile. |
|
Ok, so the proper response to my last comment would be "what threads?". The single setenv is actually left over from a previous attempt to put the setenv call into a separate task, but I couldn't get it to run before the others (tried having all the other test start with task::yield()). Anyway, I can put that part back the way it was. |
|
squashed and rebased |
ghost
assigned 
|
Assigning this to @brson to review as I don't know why this fix would work, and am afraid to merge it without understanding ;-) |
|
Thanks! Merged. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2022
avoid setting both RUSTC and RUSTC_WRAPPER Fixes rust-lang/miri#2238
BoxyUwU
pushed a commit
to BoxyUwU/rust
that referenced
this pull request
Feb 25, 2025
document how to setup RA for nvim automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick hack to address #2160 until we get some kind of global, static, singleton or whatever to fix the setenv threading problem.