-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Float::ldexp to be called as a method #22631
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Needs a rebase |
c8c79a1
to
f71e8fa
Compare
☔ The latest upstream changes (presumably #22984) made this pull request unmergeable. Please resolve the merge conflicts. |
@aepsil0n Sorry this PR totally fell through the cracks in my inbox! (Feel free to ping me or others on IRC if you're not hearing anything). Anyway, this looks good to me after a rebase. |
I wasn't around for the last days. Will rebase later. |
@aturon rebase is done. |
Thanks! @bors: r+ 316f7e8 rollup |
This fails some tests on Linux, looks like you duplicated the unit tests:
[removed from rollup] |
oops… I wasn't careful enough doing the rebase. |
⌛ Testing commit 316f7e8 with merge 32bed7a... |
fixed. |
@bors: r=aturon |
📌 Commit 5bfb5ba has been approved by |
Fixes #22098.