Fix for intermittent Windows failures, see #22628 #22648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows failures in #22628 are caused by leftover threads blocking
stdtest.exe; in both of these tests a thread is spawned that may outlive the main thread. We can't use a scoped thread here because these both test the behavior of panics in spawned threads, and with scoped threads we cannot panic the child without the parent panicking too.A twenty-second sleep for Windows ensures that the spawned thread will have exited.
This is only temporary (and is very much a hack), we probably should find a better solution to the issue of exes being blocked because they are in use, perhaps via the test runner.