doc: nits and fixes for thread API #22689
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| //! | ||
| //! ## The `Thread` type | ||
| //! | ||
| //! Already-running threads are represented via the `Thread` type, which you can | ||
| //! Threads are represented via the `Thread` type, which you can |
There was a problem hiding this comment.
Thread still only represents already-running threads.
There was a problem hiding this comment.
I removed Already-running because it doesn't work well with the line that follows it:
By spawning a new thread, e.g. using the
thread::spawnfunction.
| //! panic may optionally be detected from a different thread. If | ||
| //! the main thread panics the application will exit with a non-zero | ||
| //! the panic may optionally be detected from a different thread. If | ||
| //! the main thread panics, the application will exit with a non-zero |
There was a problem hiding this comment.
I don't think this comma is necessary
There was a problem hiding this comment.
If the comma is removed, the sentence will have to be slightly re-organised by starting with "The application...". Otherwise, the pause feels very needed.
There was a problem hiding this comment.
@alexcrichton The comma usage here is correct. See https://owl.english.purdue.edu/owl/resource/607/02/ item 2.
There was a problem hiding this comment.
Some people leave it in, some leave it out. I generally put it in. It's fine either way.
|
I may not be the best wordsmith |
|
wow, that felt long; thanks @steveklabnik |
No description provided.