int audit core::{hash, fmt}, std::sync #22700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
|
cc #22240 |
I think these are fine yeah, they're not showing up in the public API and we could perhaps add an |
|
Needs Manishearth@a5009b8 to compile on master. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
fmt and hash are pretty straightforward I think. sync is a bit more complex. I thought one or two of the `isize`s ought to be `i32`s, but that would require a bunch of casting (the root cause being the lack of atomics other than isize/usize). r? @alexcrichton
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
|
Also needs b182cd7 Might want to take a look at that (it only touches tests), since your commit message mentions some trickiness in sync. |
| let ret = LowerHex::fmt(&(*self as uint), f); | ||
| f.flags &= !(1 << (FlagV1::Alternate as uint)); | ||
| f.flags |= 1 << (FlagV1::Alternate as u32); | ||
| let ret = LowerHex::fmt(&(*self as u32), f); |
There was a problem hiding this comment.
Casting the pointer to u32 loses part of it on 64bit, see #22854. Should this be usize instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt and hash are pretty straightforward I think. sync is a bit more complex. I thought one or two of the
isizes ought to bei32s, but that would require a bunch of casting (the root cause being the lack of atomics other than isize/usize).r? @alexcrichton