std: Move std::env to the new I/O APIs #22727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
prep-env
branch
2 times, most recently
from
378206f
to
3f47b67
Compare
| /// | ||
| /// let root = Path::new("/"); | ||
| /// assert!(env::set_current_dir(&root).is_ok()); | ||
| /// println!("Successfully changed working directory to {}!", root.display()); | ||
| /// ``` | ||
| pub fn set_current_dir(p: &Path) -> IoResult<()> { | ||
| pub fn set_current_dir(p: &path::Path) -> io::Result<()> { |
|
r=me after minor nit. Fine to not expose conversions if you want to keep up the pressure. |
10 tasks
alexcrichton
force-pushed
the
prep-env
branch
10 times, most recently
from
d2a97a4
to
2d200c9
Compare
This commit moves `std::env` away from the `std::old_io` error type as well as the `std::old_path` module. Methods returning an error now return `io::Error` and methods consuming or returning paths use `std::path` instead of `std::old_path`. This commit does not yet mark these APIs as `#[stable]`. This commit also migrates `std::old_io::TempDir` to `std::fs::TempDir` with essentially the exact same API. This type was added to interoperate with the new path API and has its own `tempdir` feature. Finally, this commit reverts the deprecation of `std::os` APIs returning the old path API types. This deprecation can come back once the entire `std::old_path` module is deprecated. [breaking-change]
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 25, 2015
This commit moves `std::env` away from the `std::old_io` error type as well as the `std::old_path` module. Methods returning an error now return `io::Error` and methods consuming or returning paths use `std::path` instead of `std::old_path`. This commit does not yet mark these APIs as `#[stable]`. This commit also migrates `std::old_io::TempDir` to `std::fs::TempDir` with essentially the exact same API. This type was added to interoperate with the new path API and has its own `tempdir` feature. Finally, this commit reverts the deprecation of `std::os` APIs returning the old path API types. This deprecation can come back once the entire `std::old_path` module is deprecated. [breaking-change]
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 25, 2015
|
Needs 9f8a1cb to compile ( |
|
Also Manishearth@35eed36 |
|
⌛ Testing commit 2d200c9 with merge fa1a6e2... |
|
💔 Test failed - auto-win-64-nopt-t |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 25, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves
std::envaway from thestd::old_ioerror type as well asthe
std::old_pathmodule. Methods returning an error now returnio::Errorand methods consuming or returning paths use
std::pathinstead ofstd::old_path. This commit does not yet mark these APIs as#[stable].This commit also migrates
std::old_io::TempDirtostd::fs::TempDirwithessentially the exact same API. This type was added to interoperate with the new
path API and has its own
tempdirfeature.Finally, this commit reverts the deprecation of
std::osAPIs returning the oldpath API types. This deprecation can come back once the entire
std::old_pathmodule is deprecated.
[breaking-change]