std: Stabilize the env module
#22869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
stabilize-env
branch
2 times, most recently
from
edb40ce
to
33c9e5d
Compare
| pub fn set_exit_status(code: i32) { | ||
| EXIT_STATUS.store(code as isize, Ordering::SeqCst) | ||
| } | ||
|
|
||
| /// Fetches the process's current exit code. This defaults to 0 and can change | ||
| /// by calling `set_exit_status`. | ||
| #[unstable(feature = "env", reason = "managing the exit status may change")] |
There was a problem hiding this comment.
Hm, you can have both stable and unstable items for the same feature name?
There was a problem hiding this comment.
Hm right that does sound like a bad idea, I will move these to a new feature name.
alexcrichton
force-pushed
the
stabilize-env
branch
from
33c9e5d
to
974011f
Compare
|
@bors: r+ 974011f another one bites the dust |
|
🙀 |
|
@bors: r+ 974011f |
|
🙀 |
|
@alexcrichton Hm, want to push a trivial new commit to get a new SHA, since homu seems busted here? |
alexcrichton
force-pushed
the
stabilize-env
branch
from
974011f
to
9eb9c21
Compare
|
@bors: r=aturon 9eb9c21 |
alexcrichton
force-pushed
the
stabilize-env
branch
from
9eb9c21
to
ad14891
Compare
Now that the `std::env` module has had some time to bake this commit marks most
of its APIs as `#[stable]`. Some notable APIs that are **not** stable (and still
use the same `env` feature gate) are:
* `{set,get}_exit_status` - there are still questions about whether this is the
right interface for setting/getting the exit status of a process.
* `page_size` - this may change location in the future or perhaps name as well.
This also effectively closes rust-lang#22122 as the variants of `VarError` are
`#[stable]` now. (this is done intentionally)
|
⌛ Testing commit ad14891 with merge 3af0f10... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 28, 2015
Now that the `std::env` module has had some time to bake this commit marks most
of its APIs as `#[stable]`. Some notable APIs that are **not** stable (and still
use the same `env` feature gate) are:
* `{set,get}_exit_status` - there are still questions about whether this is the
right interface for setting/getting the exit status of a process.
* `page_size` - this may change location in the future or perhaps name as well.
This also effectively closes rust-lang#22122 as the variants of `VarError` are
`#[stable]` now. (this is done intentionally)
|
💔 Test failed - auto-linux-64-x-android-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
std::envmodule has had some time to bake this commit marks mostof its APIs as
#[stable]. Some notable APIs that are not stable (and stilluse the same
envfeature gate) are:{set,get}_exit_status- there are still questions about whether this is theright interface for setting/getting the exit status of a process.
page_size- this may change location in the future or perhaps name as well.This also effectively closes #22122 as the variants of
VarErrorare#[stable]now. (this is done intentionally)