Skip to content

Fix {:p} truncating pointers to 32 bits #22901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2015
Merged

Conversation

thepowersgang
Copy link
Contributor

A misplaced uint->u32 instead of usize in fmt::Pointer. Added a basic test.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@thepowersgang
Copy link
Contributor Author

@bors: r=eddyb

@eddyb
Copy link
Member

eddyb commented Feb 28, 2015

@bors r+ c22d026 rollup

@Manishearth
Copy link
Member

Needs ad3ae5f

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 28, 2015
 A misplaced uint->u32 instead of usize in fmt::Pointer. Added a basic test.
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 28, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2015
 A misplaced uint->u32 instead of usize in fmt::Pointer. Added a basic test.
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2015
@bors bors merged commit c22d026 into rust-lang:master Mar 1, 2015
@thepowersgang thepowersgang deleted the patch-1 branch March 2, 2015 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants