Fixed typo and example in the introduction. #22947
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
ic
changed the title
|
☔ The latest upstream changes (presumably #22963) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@alexandercampbell Thanks for the note. It was a tiny typo anyway ;-) How about the change to the concurrency example? The first time I read the section, I wished for more "connected" examples. Simple edit, and tested on nightly. |
|
@lc I agree making them more consistent is good, thanks! However, you have a merge commit in here, would you mind rebasing that out? r=me after. |
The failing concurrency example was doing something different from the working example. This commit changes just enough of the failing example to (1) still fail with the same error, (2) tries to do the same as the working example (increment a vector value and print it). r? @steveklabnik
ic
force-pushed
the
master
branch
2 times, most recently
from
040b60a to
dde4e58
Compare
|
@steveklabnik Thank you for the feedback. I have set the repository HEAD at the commit. I have also removed the conflicting commit related to @alexandercampbell' s contribution. I chose to proceed this way, as pulling the master from @alexandercampbell Ok, thank you. Let's get some more in ;-) |
|
Looks good, thank you! |
Changed guaranteed for \"quaranteed\", and Made failing/working examples look alike. r? @steveklabnik
Changed guaranteed for "quaranteed", and
Made failing/working examples look alike.
r? @steveklabnik