Skip to content

Allow quasi-quoting Question tokens (issue #22957) #23019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rschifflin
Copy link

Resolves #22957 by adding Question to the list of token names used by the quasi-quote token builder.

Should the associated test be given any directives for ignore-pretty or ignore-android like similar tests?

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@rschifflin
Copy link
Author

#23018 was too quick for me!

@rschifflin rschifflin closed this Mar 4, 2015
@rschifflin rschifflin deleted the issue-22957 branch March 4, 2015 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE when quasi-quoting ?Sized trait bound
3 participants