trans: Add early-out when translating unreachable controlflow expressions. #23066
+128
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -83,3 +163,5 @@ fn main() { | |||
| fn diverge() -> ! { | |||
| panic!(); | |||
| } | |||
|
|
|||
| fn some_predicate() -> bool { true || false } | |||
There was a problem hiding this comment.
Thanks, fixed that.
michaelwoerister
force-pushed
the
unreachable-if
branch
from
52e6a1b to
e05c2f8
Compare
|
r? @pnkfelix |
|
@bors r+ |
|
📌 Commit e05c2f8 has been approved by |
|
@bors rollup |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 1, 2015
…pnkfelix This PR solves rust-lang#21559 by making sure that unreachable if-expressions are not further translated. Could someone who knows their way around `trans` take a look at the changes in `controlflow.rs`? I'm not sure if any other code relies on any side-effects of translating unreachable things. cc @nikomatsakis @nrc @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #21559 by making sure that unreachable if-expressions are not further translated.
Could someone who knows their way around
transtake a look at the changes incontrolflow.rs? I'm not sure if any other code relies on any side-effects of translating unreachable things.cc @nikomatsakis @nrc @eddyb