Stabilize std::path #23229
Merged
Stabilize std::path #23229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this needs to be rebased and complete testing on Windows, but it otherwise ready for review. |
| @@ -1324,11 +1368,14 @@ impl cmp::Ord for Path { | |||
| } | |||
|
|
|||
| /// Freely convertible to a `Path`. | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| pub trait AsPath { | |||
There was a problem hiding this comment.
Should this hold off on being stable while generic conversion traits are landing?
There was a problem hiding this comment.
My impression was that this was one of the motivating reasons for generic conversion traits, so yeah we probably want to wait for that.
|
A few nits here and there, otherwise r=me |
|
Comments addressed. Will send to bors once it passes tests locally. |
aturon
force-pushed
the
stab-path
branch
2 times, most recently
from
b91a0bb to
4082f1c
Compare
|
cc #23283, a case where the semantics of |
aturon
force-pushed
the
stab-path
branch
3 times, most recently
from
32ee399 to
92475b8
Compare
This commit stabilizes essentially all of the new `std::path` API. The
API itself is changed in a couple of ways (which brings it in closer
alignment with the RFC):
* `.` components are now normalized away, unless they appear at the
start of a path. This in turn effects the semantics of e.g. asking for
the file name of `foo/` or `foo/.`, both of which yield `Some("foo")`
now. This semantics is what the original RFC specified, and is also
desirable given early experience rolling out the new API.
* The `parent` function now succeeds if, and only if, the path has at
least one non-root/prefix component. This change affects `pop` as
well.
* The `Prefix` component now involves a separate `PrefixComponent`
struct, to better allow for keeping both parsed and unparsed prefix data.
In addition, the `old_path` module is now deprecated.
Closes rust-lang#23264
[breaking-change]
bors
added a commit
that referenced
this pull request
Mar 13, 2015
This commit stabilizes essentially all of the new `std::path` API. The
API itself is changed in a couple of ways (which brings it in closer
alignment with the RFC):
* `.` components are now normalized away, unless they appear at the
start of a path. This in turn effects the semantics of e.g. asking for
the file name of `foo/` or `foo/.`, both of which yield `Some("foo")`
now. This semantics is what the original RFC specified, and is also
desirable given early experience rolling out the new API.
* The `parent` method is now `without_file` and succeeds if, and only
if, `file_name` is `Some(_)`. That means, in particular, that it fails
for a path like `foo/../`. This change affects `pop` as well.
In addition, the `old_path` module is now deprecated.
[breaking-change]
r? @alexcrichton
This was referenced Mar 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stabilizes essentially all of the new
std::pathAPI. TheAPI itself is changed in a couple of ways (which brings it in closer
alignment with the RFC):
.components are now normalized away, unless they appear at thestart of a path. This in turn effects the semantics of e.g. asking for
the file name of
foo/orfoo/., both of which yieldSome("foo")now. This semantics is what the original RFC specified, and is also
desirable given early experience rolling out the new API.
parentmethod is nowwithout_fileand succeeds if, and onlyif,
file_nameisSome(_). That means, in particular, that it failsfor a path like
foo/../. This change affectspopas well.In addition, the
old_pathmodule is now deprecated.[breaking-change]
r? @alexcrichton