Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Arc usage in introduction #23277

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Remove unnecessary Arc usage in introduction #23277

merged 1 commit into from
Apr 7, 2015

Conversation

aochagavia
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

Hmm, the point is to introduce comboing Arc and Mutex together. The examples have gotten a bit out of sync from each other, I think, but I'm not sure this is the right way to address this. Thoughts?

@aochagavia
Copy link
Contributor Author

I also think it is nice to introduce Arc. However, I think it is difficult to find a trivial example where it makes sense to use it (probably with detached threads).

@huonw
Copy link
Member

huonw commented Apr 6, 2015

r? @steveklabnik (transferring reviewership, don't have the bandwidth right now.)

@rust-highfive rust-highfive assigned steveklabnik and unassigned huonw Apr 6, 2015
@steveklabnik
Copy link
Member

I'm planning on doing more overhauls to this section, but let's just merge this for now, and we'llsee how it ends up.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Apr 6, 2015

📌 Commit 5a82a81 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Apr 7, 2015

⌛ Testing commit 5a82a81 with merge b41f2df...

bors added a commit that referenced this pull request Apr 7, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2015
@bors bors merged commit 5a82a81 into rust-lang:master Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants