implements read_into_string/read_into_vec for Read trait #23335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This implements RFC0841
|
☔ The latest upstream changes (presumably #23292) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Waiting on RFC. |
|
I went ahead and put this out as a readext crate on crates.io. |
|
The associated RFC was closed, so I'm going to close this as well. Thanks regardless @cburgdorf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements RFC0841. It hasn't been decided the RFC gets accepted but I wanted to come up with an PR early on that I maintain as the RFC evolves.
It's also missing tests yet. It's my first real code change to the Rust project so I gotta figure out how to do things properly and run the test suite etc.