syntax: Document the AST #23428
syntax: Document the AST #23428
Conversation
|
👍 |
Manishearth
force-pushed
the
ast-doc
branch
4 times, most recently
from
169034f
to
9d2ffab
Compare
| pub expr: Option<P<Expr>>, | ||
| pub id: NodeId, | ||
| /// Unsafety of the block |
There was a problem hiding this comment.
Maybe "distinguishes between unsafe { ... } and { ... }.
|
Looks great; just a few little nits. (r=me once fixed) |
|
In the future it may be worth considering converting some of the variants into struct variants so that the types are more self-documenting. |
|
@bors: r=huon |
|
📌 Commit a5828ff has been approved by |
I often have to run `ast-json` or look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff). r? @steveklabnik f? @eddyb
| ExprVec(Vec<P<Expr>>), | ||
| /// A function call | ||
| /// The first field resolves to the function itself, |
There was a problem hiding this comment.
you need a line break between these two unless you want them to get rendered all together
|
This is missing a ton of periods at the end of buches of summaries. other than that and the few other things I mentioned, looks pretty good. |
|
☔ The latest upstream changes (presumably #23473) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors: r=steveklabnik rollup (Sadly, only part of this could merge in the rollup) |
|
📌 Commit 6de89f5 has been approved by |
I often have to run `ast-json` or look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff). r? @steveklabnik f? @eddyb
I often have to run
ast-jsonor look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff).r? @steveklabnik
f? @eddyb