Skip default methods if normalization fails #23486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, that test actually doesn't ICE when you are not on sfackler's branch. I don't really understand why not though. |
nikomatsakis
force-pushed
the
issue-23485
branch
from
b1ac56d
to
fc2b063
Compare
|
OK, I think I have a test that represents the issue now :) |
nikomatsakis
force-pushed
the
issue-23485
branch
2 times, most recently
from
eb0e249
to
14755cb
Compare
| pub fn is_vtable_safe_method<'tcx>(tcx: &ty::ctxt<'tcx>, | ||
| trait_def_id: ast::DefId, | ||
| method: &ty::Method<'tcx>) | ||
| -> bool |
|
r+ modulo nits |
Merged
|
Ping? |
|
@sfackler argh let me address those nits... |
combine normalization with this check so that we also skip the default method if normalization fails. Fixes rust-lang#23485.
nikomatsakis
force-pushed
the
issue-23485
branch
from
14755cb
to
70042cf
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2015
When testing whether a default method predicates are satisfiable, combine normalization with this check so that we also skip the default method if normalization fails. Fixes rust-lang#23485. r? @nrc (I tried to address your nit from before as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing whether a default method predicates are satisfiable,
combine normalization with this check so that we also skip the
default method if normalization fails. Fixes #23485.
r? @nrc (I tried to address your nit from before as well)