Comment on when ReadDir is Err #23529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
| /// # Failure | ||
| /// | ||
| /// This `io::Result` will be an `Err` if there's some problem reading the | ||
| /// directory, for example, if it does not exist. |
There was a problem hiding this comment.
I think this may not be quite the error that we're looking for because a nonexistent directory should return an error from the initial read_dir function call, not halfway through iteration. I haven't been able to find some great documentation on when this can fail or not, but I think it's fine to just say something about intermittent I/O errors perhaps.
|
@alexcrichton fair enough, updated! |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23426