Derive missing trait implementations for cursor #23607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I commented on your issue to say I was working on it but whatever... I made a different Debug implementation so I'll create my own PR. EDIT: My pr is #23609. Your implementation would display the inner buffer too if I'm not wrong and that's not what we would want in here. |
| @@ -31,6 +31,7 @@ use slice; | |||
| /// over `T` itself. Instead, specific implementations are provided for various | |||
| /// in-memory buffer types like `Vec<u8>` and `&[u8]`. | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| #[derive(Copy, Clone, Debug, Eq, PartialEq)] | |||
There was a problem hiding this comment.
Can this leave out Copy for now? I've generally tried to avoid that wherever possible. I also think that it's fine to remove Eq/PartialEq as they should be pretty easy to add back in the future, and I think that comparing I/O objects for equality is a pretty rare operation.
|
Updated. |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 23, 2015
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
- Successful merges: rust-lang#22954, rust-lang#23119, rust-lang#23509, rust-lang#23561, rust-lang#23590, rust-lang#23607, rust-lang#23608, rust-lang#23618, rust-lang#23622, rust-lang#23639, rust-lang#23641 - Failed merges: rust-lang#23401
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23599
r? @alexcrichton