-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pointers.md #23690
Update pointers.md #23690
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
This change looks unnecessary, why is it needed? |
It may be my mistake but lines 458 through 475 in the doc imply that &*box_var is the proper way of casting a Box pointer to a reference pointer. The same syntax is used on line 554. |
There are now deref coercions which make The other docs might want to be updated, or it's possible that this is correct given that the coercions are not yet introduced. Thanks for the extra context. |
Yes and in addition to what @richo mentioned we tend to shy away from |
I am happy with merging this as-is, and I will come back and do stuff about deref coercions. This chapter needs a lot of work anyway, and with associated types merged, i'll get on it soon. |
@bors: r+ rollup |
📌 Commit 053d58e has been approved by |
No description provided.