Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pointers.md #23690

Merged
merged 1 commit into from
Mar 28, 2015
Merged

Update pointers.md #23690

merged 1 commit into from
Mar 28, 2015

Conversation

wettowelreactor
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@richo
Copy link
Contributor

richo commented Mar 25, 2015

This change looks unnecessary, why is it needed?

@wettowelreactor
Copy link
Contributor Author

It may be my mistake but lines 458 through 475 in the doc imply that &*box_var is the proper way of casting a Box pointer to a reference pointer. The same syntax is used on line 554.

@richo
Copy link
Contributor

richo commented Mar 25, 2015

There are now deref coercions which make Box<T> deref to a T automatically when required (http://is.gd/N9eDzD), which is why I was surprised by this patch.

The other docs might want to be updated, or it's possible that this is correct given that the coercions are not yet introduced. Thanks for the extra context.

@alexcrichton
Copy link
Member

Yes and in addition to what @richo mentioned we tend to shy away from &* wherever possible (e.g. it shouldn't be necessary in normal code). I think that some of the surrounding examples may want to be borrowed as well, but @steveklabnik may also have a better idea of how to introduce deref coercions (or if they should be used at all).

r? @steveklabnik

@steveklabnik
Copy link
Member

I am happy with merging this as-is, and I will come back and do stuff about deref coercions. This chapter needs a lot of work anyway, and with associated types merged, i'll get on it soon.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 25, 2015

📌 Commit 053d58e has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
erickt added a commit to erickt/rust that referenced this pull request Mar 26, 2015
erickt added a commit to erickt/rust that referenced this pull request Mar 26, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2015
@bors bors merged commit 053d58e into rust-lang:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants