Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New section of the book: nightly rust #23719

Merged
merged 1 commit into from
Mar 28, 2015
Merged

New section of the book: nightly rust #23719

merged 1 commit into from
Mar 28, 2015

Conversation

steveklabnik
Copy link
Member

Now that feature flags are only on nightly, it's good to split this stuff out.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member Author

This diff is basically just extracting all the parts of the book out, with the exception of trace_macros. The rest of it is just verbatim copy/paste.

@alexcrichton
Copy link
Member

Is the empty file src/doc/trpl/tracing-macros.md intentional?

@steveklabnik
Copy link
Member Author

Uh, no. Whoops!

alexcrichton
alexcrichton reviewed Mar 25, 2015
View reviewed changes
src/doc/trpl/unsafe.md
the compiler to insert its usual stack alignment code
3. *intel* - use intel syntax instead of the default AT&T.

# Avoiding the standard library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section appears to have disappeared, was that intentional? (I'm ok if it was)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait nevermind this header just changed names and my search-fu failed me

@alexcrichton
Copy link
Member

@bors: r+ rollup

Nice idea!

@bors
Copy link
Contributor

bors commented Mar 25, 2015

📌 Commit 7ef73ce has been approved by alexcrichton

@steveklabnik
Copy link
Member Author

🎊

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
@Manishearth
Rollup merge of rust-lang#23719 - steveklabnik:unstable_book, r=alexc…
7bf66b3 
…richton

Now that feature flags are only on nightly, it's good to split this stuff out.
@Manishearth Manishearth mentioned this pull request Mar 26, 2015
Closed
@erickt
Copy link
Contributor

erickt commented Mar 26, 2015

I think this errored out in the rollup with:

rustc: x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/librustc_llvm
rustc: x86_64-apple-darwin/stage1/lib/rustlib/x86_64-apple-darwin/bin/rustbook
rustc: x86_64-apple-darwin/stage1/lib/rustlib/x86_64-apple-darwin/bin/rustdoc
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/driver/driver.rs:15:14: 15:23 warning: obsolete syntax: "crate-name"
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/driver/driver.rs:15 extern crate "rustdoc" as this;
                                                                                                    ^~~~~~~~~
note: use an identifier not in quotes instead
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/driver/driver.rs:18:14: 18:28 warning: obsolete syntax: "crate-name"
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/driver/driver.rs:18 extern crate "rustc_driver" as this;
                                                                                                    ^~~~~~~~~~~~~~
cp: x86_64-apple-darwin/stage2/lib/librustdoc
rustc: x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libterm
rustc: x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libserialize
cp: x86_64-apple-darwin/stage2/bin/rustbook
cp: x86_64-apple-darwin/stage2/bin/rustdoc
rustbook: doc/book/index.html
error: No such file or directory (os error 2)
make: *** [doc/book/index.html] Error 101
make: *** Waiting for unfinished jobs....
program finished with exit code 2
elapsedTime=2077.192005

@steveklabnik
New section of the book: nightly rust
c153fc1 
Now that feature flags are only on nightly, it's good to split this stuff out.
@steveklabnik
Copy link
Member Author

I don't know what caused this error, but I'll rebase in case there's something weird, and let's just non-rollup this one.

@steveklabnik
Copy link
Member Author

@bors: r=alexcrichton

@bors
Copy link
Contributor

bors commented Mar 26, 2015

📌 Commit c153fc1 has been approved by alexcrichton

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2015
@Manishearth
Rollup merge of rust-lang#23719 - steveklabnik:unstable_book, r=alexc…
69cc54e 
…richton

 Now that feature flags are only on nightly, it's good to split this stuff out.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2015
@alexcrichton
rollup merge of rust-lang#23719: steveklabnik/unstable_book
8eb918e 
Now that feature flags are only on nightly, it's good to split this stuff out.
@bors bors merged commit c153fc1 into rust-lang:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@steveklabnik @rust-highfive @alexcrichton @bors @erickt