Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes in libc extern crate std as core #23723

Closed
wants to merge 1 commit into from

Conversation

theemathas
Copy link
Contributor

Get rid of that weird note: use an identifier not in quotes instead when using the libc crate.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

Unfortunately this is not currently possible as a snapshot is needed for this syntax to work at stage0. We'll be sure to update this though once a new snapshot is registered!

@SSheldon
Copy link
Contributor

@alexcrichton, won't this be ignored in the stage0 build because of #[cfg(feature = "cargo-build")]?

@alexcrichton
Copy link
Member

I believe it will trigger a parse error unless the snapshots are registered. The new snapshots should land in #23738.

@theemathas theemathas deleted the libc-no-quotes branch March 8, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants