rustc: Remove support for old_impl_check #23749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes compiler support for the `old_impl_check` attribute which should in theory be entirely removed now. The last remaining use of it in the standard library has been updated by moving the type parameter on the `old_io::Acceptor` trait into an associated type. As a result, this is a breaking change for all current users of the deprecated `old_io::Acceptor` trait. Code can be migrated by using the `Connection` associated type instead. [breaking-change]
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
/me excited |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 26, 2015
… r=nikomatsakis This commit removes compiler support for the `old_impl_check` attribute which should in theory be entirely removed now. The last remaining use of it in the standard library has been updated by moving the type parameter on the `old_io::Acceptor` trait into an associated type. As a result, this is a breaking change for all current users of the deprecated `old_io::Acceptor` trait. Code can be migrated by using the `Connection` associated type instead. [breaking-change]
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2015
Conflicts: src/libsyntax/feature_gate.rs
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes compiler support for the
old_impl_checkattribute whichshould in theory be entirely removed now. The last remaining use of it in the
standard library has been updated by moving the type parameter on the
old_io::Acceptortrait into an associated type. As a result, this is abreaking change for all current users of the deprecated
old_io::Acceptortrait. Code can be migrated by using the
Connectionassociated type instead.[breaking-change]