Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloc: Don't run some Arc doc tests #23775

Merged
merged 1 commit into from
Mar 28, 2015
Merged

Conversation

alexcrichton
Copy link
Member

Windows gets quite unhappy when a thread fails while the main thread is exiting,
frequently leading to process deadlock. This has been causing quite a few
deadlocks on the windows bots recently. The child threads are presumably failing
because the println! is failing due to the main thread being shut down.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 27, 2015

📌 Commit 95376dd has been approved by Manishearth

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Windows gets quite unhappy when a thread fails while the main thread is exiting,
frequently leading to process deadlock. This has been causing quite a few
deadlocks on the windows bots recently. The child threads are presumably failing
because the `println!` is failing due to the main thread being shut down.
@alexcrichton
Copy link
Member Author

@bors: r=Manishearth fa38403

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Windows gets quite unhappy when a thread fails while the main thread is exiting,
frequently leading to process deadlock. This has been causing quite a few
deadlocks on the windows bots recently. The child threads are presumably failing
because the `println!` is failing due to the main thread being shut down.
@bors bors merged commit fa38403 into rust-lang:master Mar 28, 2015
@alexcrichton alexcrichton deleted the fix-flaky-test branch March 28, 2015 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants