Update debug helpers and use it for stdlib collections #23810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
The collections debug helpers no longer prefix output with the collection name, in line with the current conventions for Debug implementations. Implementations that want to preserve the current behavior can simply add a `try!(write!(fmt, "TypeName "));` at the beginning of the `fmt` method. [breaking-change]
sfackler
force-pushed
the
debug-collections
branch
from
cb97126
to
4037f2a
Compare
| } | ||
|
|
||
| write!(f, "}}") | ||
| builder.finish() |
There was a problem hiding this comment.
This may actually be a prime spot for a fold:
self.iter().fold(f.debug_map(), |b, (k, v)| b.entry(k, v)).finish()
|
r=me with some |
|
By the way, |
|
Yeah that sounds good to me |
Also convert [T]'s Debug impl. The behavior of the alternate flag here's changing.
|
@bors r=alexcrichton 14926ca |
|
⌛ Testing commit 14926ca with merge b37e37e... |
|
💔 Test failed - auto-mac-64-opt |
sfackler
force-pushed
the
debug-collections
branch
from
14926ca
to
842e6cf
Compare
|
@bors r=alexcrichton 10feb40 |
|
⌛ Testing commit 10feb40 with merge c67e4b4... |
|
💔 Test failed - auto-mac-64-opt |
sfackler
force-pushed
the
debug-collections
branch
from
10feb40
to
3c0c8fc
Compare
bors
added a commit
that referenced
this pull request
Mar 29, 2015
The collections debug helpers no longer prefix output with the collection name, in line with the current conventions for Debug implementations. Implementations that want to preserve the current behavior can simply add a `try!(write!(fmt, "TypeName "));` at the beginning of the `fmt` method. [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collections debug helpers no longer prefix output with the
collection name, in line with the current conventions for Debug
implementations. Implementations that want to preserve the current
behavior can simply add a
try!(write!(fmt, "TypeName "));at thebeginning of the
fmtmethod.[breaking-change]