-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example for FromIterator::from_iter #23816
Conversation
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #23300) made this pull request unmergeable. Please resolve the merge conflicts. |
b96d6df
to
b7ae349
Compare
/cc @steveklabnik since this is docs related |
This looks good to me. r=me with or without the following change: While we're at it, could we have an example that uses |
b7ae349
to
f6d1ad8
Compare
@Manishearth How's that? |
/// let colors_set = colors_vec.into_iter().collect::<HashSet<&str>>(); | ||
/// assert_eq!(colors_set.len(), 3); | ||
/// ``` | ||
assert_eq!(colors_set.len(), 3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line seems to be a mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Fixed in latest push
f6d1ad8
to
8fe7f1f
Compare
@bors: r+ rollup |
📌 Commit 8fe7f1f has been approved by |
No description provided.