Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong name of test module in testing.md #23839

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Conversation

tyrion
Copy link
Contributor

@tyrion tyrion commented Mar 29, 2015

The documentation says that 'The current convention is to use the test module
to hold your "unit-style"' but then defines the module as "tests" instead.

Also in the output of the command we can see:

test test::it_works ... ok

So I think the name of the module was meant to be "test"

The documentation says that 'The current convention is to use the `test` module
to hold your "unit-style"' but then defines the module as "tests" instead.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+ b77a09c rollup

@bors
Copy link
Contributor

bors commented Mar 30, 2015

⌛ Testing commit b77a09c with merge cc2d66c...

@bors
Copy link
Contributor

bors commented Mar 30, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Mar 30, 2015 at 1:49 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4266


Reply to this email directly or view it on GitHub
#23839 (comment).

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 31, 2015
The documentation says that 'The current convention is to use the `test` module
to hold your "unit-style"' but then defines the module as "tests" instead.

Also in the output of the command we can see:
```
test test::it_works ... ok
```
So I think the name of the module was meant to be "test"
bors added a commit that referenced this pull request Mar 31, 2015
@bors bors merged commit b77a09c into rust-lang:master Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants