Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcore: Ensure min and max functions are consistent for equal inputs #23878

Merged
merged 1 commit into from
Apr 1, 2015

Conversation

Ryman
Copy link
Contributor

@Ryman Ryman commented Mar 31, 2015

min-like functions now return the leftmost element/input for equal elements.
max-like return the rightmost.

Closes #23687.

cc @HeroesGrave, @aturon, @alexcrichton

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 2a89d69

Thanks!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 31, 2015
`min`-like functions now return the leftmost element/input for equal elements.
`max`-like return the rightmost.

Closes rust-lang#23687.

cc @HeroesGrave, @aturon, @alexcrichton
@bors bors merged commit 2a89d69 into rust-lang:master Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmp: min/max is inconsistent with partial_min/max on certain edge cases
5 participants