Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples and documentation for std::fs #23931

Merged
merged 1 commit into from
Apr 2, 2015

Conversation

steveklabnik
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@andrew-d
Copy link
Contributor

andrew-d commented Apr 1, 2015

🍰

@bors
Copy link
Contributor

bors commented Apr 1, 2015

☔ The latest upstream changes (presumably #23936) made this pull request unmergeable. Please resolve the merge conflicts.

/// # Examples
///
/// ```
/// use std::fs;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import I don't believe is necessary in most of these exampels.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@alexcrichton
Copy link
Member

Nice!

@steveklabnik
Copy link
Member Author

@alexcrichton r? updated to address all nits

@alexcrichton
Copy link
Member

@bors: r+ 1873551

@bors
Copy link
Contributor

bors commented Apr 2, 2015

⌛ Testing commit 1873551 with merge d1835ae...

@bors bors merged commit 1873551 into rust-lang:master Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants