libc: unbreak severals os/platform #23967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affected struct: - sockaddr_storage - sockaddr_un apply the same method used for linux for: - bitrig/openbsd - freebsd - dragonfly
unbreak build for: - linux (mips/mipsel) - freebsd - dragonfly - bitrig - openbsd by converting unsigned integers `-1` to `!0`
|
the first patch is for #23860 |
|
the second patch follow f86318d unbreak build for:
by converting unsigned integers |
semarie
changed the title
bors
added a commit
that referenced
this pull request
Apr 2, 2015
affected struct: - sockaddr_storage - sockaddr_un apply the same method used for linux for: - bitrig/openbsd - freebsd - dragonfly this commit unbreak build for openbsd (and bitrig, freebsd and dragonfly too I think) r? @alexcrichton
|
Just as side note, the compilation for other targets than openbsd have been tested for:
|
|
Thank you @semarie! The test suite is still running on my FreeBSD 10.1 system but I see the build bot passed. Thank you for fixing so many of the recent *BSD breakages! |
|
@alexcrichton these commits are needed for beta under openbsd (and all others targets affected by this problem). Is it possible to import them to beta ? |
|
We're likely to update the beta branch to the master branch for the next week or two as some final changes trickle in, so this should hopefully get picked up soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affected struct:
apply the same method used for linux for:
this commit unbreak build for openbsd (and bitrig, freebsd and dragonfly too I think)
r? @alexcrichton