Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the wrapper RefCell from around DefMap #24096

Closed
wants to merge 8 commits into from
Closed

Remove the wrapper RefCell from around DefMap #24096

wants to merge 8 commits into from

Conversation

gereeter
Copy link
Contributor

@gereeter gereeter commented Apr 5, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@sanxiyn
Copy link
Member

sanxiyn commented Apr 9, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Apr 9, 2015

📌 Commit 0105960 has been approved by sanxiyn

@bors
Copy link
Contributor

bors commented Apr 9, 2015

⌛ Testing commit 0105960 with merge bf09b3a...

@bors
Copy link
Contributor

bors commented Apr 9, 2015

💔 Test failed - auto-mac-64-opt

@bors
Copy link
Contributor

bors commented Apr 16, 2015

☔ The latest upstream changes (presumably #24306) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to reopen with a rebase and the tests fixed!

@gereeter gereeter mentioned this pull request Nov 4, 2015
Merged
bors added a commit that referenced this pull request Nov 5, 2015
@bors
Auto merge of #29581 - gereeter:unwrap-defmap-refcell, r=nrc
7839827 
This is basically a more conservative recreation of #24096.
@gereeter gereeter deleted the defmap-no-refcell branch December 17, 2015 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gereeter @rust-highfive @sanxiyn @bors @alexcrichton @brson