-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkup in tail function and return Option type #24172
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
ac36b1f
to
eb6d3f5
Compare
This makes |
I'm working on a separate PR that implements my proposal, of replacing |
My PR has been submitted as #24184. |
Hmm. @kballard's PR is a bit more ambitious, so they're not directly comparable; but at minimum I agree that having |
eb6d3f5
to
2bdd6f6
Compare
☔ The latest upstream changes (presumably #24674) made this pull request unmergeable. Please resolve the merge conflicts. |
I think I'm going to close this due to rust-lang/rfcs#1058 -- let's see how that pans out, but that approach in some form seems to be popular. |
Thanks @GuillaumeGomez for the PR in any case! |
Fixes #24141.