Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Stabilize io::Error::from_raw_os_error #24216

Merged
merged 1 commit into from
Apr 9, 2015

Conversation

alexcrichton
Copy link
Member

This commit stabilizes the old io::Error::from_os_error after being renamed to
use the raw_os_error terminology instead. This function is often useful when
writing bindings to OS functions but only actually converting to an I/O error at
a later point.

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned pcwalton Apr 8, 2015
@aturon
Copy link
Member

aturon commented Apr 8, 2015

cc @carllerche

@aturon
Copy link
Member

aturon commented Apr 8, 2015

Do you mind keeping the original name as deprecated? We'll be doing a deprecation clear before 1.0 anyway.

Otherwise r=me.

This commit stabilizes the old `io::Error::from_os_error` after being renamed to
use the `raw_os_error` terminology instead. This function is often useful when
writing bindings to OS functions but only actually converting to an I/O error at
a later point.
@alexcrichton alexcrichton force-pushed the stabilize-from-raw-os-error branch from 7ec8e2c to 561fdec Compare April 8, 2015 23:50
@alexcrichton
Copy link
Member Author

@bors: r=aturon 561fdec

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 9, 2015
…error, r=aturon

 This commit stabilizes the old `io::Error::from_os_error` after being renamed to
use the `raw_os_error` terminology instead. This function is often useful when
writing bindings to OS functions but only actually converting to an I/O error at
a later point.
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 9, 2015
…error, r=aturon

 This commit stabilizes the old `io::Error::from_os_error` after being renamed to
use the `raw_os_error` terminology instead. This function is often useful when
writing bindings to OS functions but only actually converting to an I/O error at
a later point.
@bors bors merged commit 561fdec into rust-lang:master Apr 9, 2015
@alexcrichton alexcrichton deleted the stabilize-from-raw-os-error branch April 30, 2015 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants