Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for an escaping closure #24242

Merged
merged 4 commits into from
Apr 11, 2015
Merged

Improve error message for an escaping closure #24242

merged 4 commits into from
Apr 11, 2015

Commits on Apr 10, 2015

  1. Replace the use of the rather randomly named boolean custom to mean 

    "highlight end" and instead add a variant to `RenderSpan`
    @nikomatsakis
    nikomatsakis committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    16574e3 View commit details
    Browse the repository at this point in the history

  2. Modify the codemap code to use more slices and to information about 

    columns within a line, not just the line numbers. Also try to clarify
and use the term `line_index` when 0-based.
    @nikomatsakis
    nikomatsakis committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    5156b3a View commit details
    Browse the repository at this point in the history

  3. Add a new span_suggestion infrastructure. This lets you edit a snippet 

    of text (perhaps obtained by span_snippet) and then splice that edited
form back into the original file in the form of a suggestion.
    @nikomatsakis
    nikomatsakis committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    906a972 View commit details
    Browse the repository at this point in the history

  4. Improve error message where a closure escapes fn while trying to borrow 

    from the current fn. Employ the new `span_suggestion` to show how you
can use `move`.
    @nikomatsakis
    nikomatsakis committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    e313b33 View commit details
    Browse the repository at this point in the history