Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the wording of the documentation for the insert method for Vec ... #24279

Merged
merged 1 commit into from
Apr 11, 2015

Conversation

libfud
Copy link

@libfud libfud commented Apr 10, 2015

...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.

r? @steveklabnik

…c to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 10, 2015

📌 Commit cdce32f has been approved by steveklabnik

@steveklabnik
Copy link
Member

@bors: rollup

@steveklabnik
Copy link
Member

Thank you!

@libfud
Copy link
Author

libfud commented Apr 10, 2015

No problem, more than happy to contribute, even if it's a diff of two lines.

@steveklabnik
Copy link
Member

No diff is too small!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 10, 2015
…labnik

...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.

r? @steveklabnik
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 10, 2015
…labnik

...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.

r? @steveklabnik
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 10, 2015
…labnik

...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.

r? @steveklabnik
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 11, 2015
…labnik

 ...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.

r? @steveklabnik
@bors bors merged commit cdce32f into rust-lang:master Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants