Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Remove old_io/old_path/rand #24303

Merged
merged 12 commits into from
Apr 15, 2015
Merged

Conversation

alexcrichton
Copy link
Member

This commit removes these long deprecated modules. Such a nice diff stat!

@alexcrichton
Copy link
Member Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned brson Apr 10, 2015
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton force-pushed the remove-deprecated branch 5 times, most recently from a57d713 to 9976ffc Compare April 10, 2015 22:07
@aturon
Copy link
Member

aturon commented Apr 10, 2015

This makes me happy :)

r=me once it's passing tests for you.

@alexcrichton alexcrichton force-pushed the remove-deprecated branch 2 times, most recently from 5be29a8 to e97df69 Compare April 10, 2015 22:58
@alexcrichton
Copy link
Member Author

@bors: r=aturon

@bors
Copy link
Collaborator

bors commented Apr 10, 2015

📌 Commit e97df69 has been approved by aturon

@alexcrichton
Copy link
Member Author

@bors: r=aturon 6caa15a

@bors
Copy link
Collaborator

bors commented Apr 11, 2015

⌛ Testing commit 6caa15a with merge 1902376...

@tshepang
Copy link
Member

This is some seriously epic trimming!

@bors
Copy link
Collaborator

bors commented Apr 11, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton
Copy link
Member Author

@bors: r=aturon 4a1b53f

@bors
Copy link
Collaborator

bors commented Apr 13, 2015

⌛ Testing commit 4a1b53f with merge 23e29bb...

@bors
Copy link
Collaborator

bors commented Apr 13, 2015

💔 Test failed - auto-mac-32-opt

@nagisa
Copy link
Member

nagisa commented Apr 13, 2015

I think we could easily remove all distributions code.

@alexcrichton
Copy link
Member Author

@bors: r=aturon 0b95b9b

@bors
Copy link
Collaborator

bors commented Apr 13, 2015

☔ The latest upstream changes (presumably #24198) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member Author

@bors: r=aturon

On Mon, Apr 13, 2015 at 1:41 PM, bors notifications@github.com wrote:

[image: ☔] The latest upstream changes (presumably #24198
#24198) made this pull request
unmergeable. Please resolve the merge conflicts.


Reply to this email directly or view it on GitHub
#24303 (comment).

@bors
Copy link
Collaborator

bors commented Apr 13, 2015

📌 Commit 339b311 has been approved by aturon

@bors
Copy link
Collaborator

bors commented Apr 14, 2015

🔒 Merge conflict

@bors
Copy link
Collaborator

bors commented Apr 14, 2015

☔ The latest upstream changes (presumably #24261) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member Author

@bors: r=aturon 78028ed

@bors
Copy link
Collaborator

bors commented Apr 14, 2015

☔ The latest upstream changes (presumably #24312) made this pull request unmergeable. Please resolve the merge conflicts.

This commit entirely removes the old I/O, path, and rand modules. All
functionality has been deprecated and unstable for quite some time now!
Just bind the relevant platform-specific functions we should probably be calling
anyway.
Needed to get modules like rustc_back::tempdir compiling.
This apparently fixes obscure bugs on OSX!
None of these actually compile any more!
@alexcrichton
Copy link
Member Author

@bors: r=aturon b8760af

@bors
Copy link
Collaborator

bors commented Apr 14, 2015

⌛ Testing commit b8760af with merge 6a21c70...

@bors
Copy link
Collaborator

bors commented Apr 14, 2015

💔 Test failed - auto-win-64-opt

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 14, 2015
This commit removes these long deprecated modules. Such a nice diff stat!
@bors bors merged commit b8760af into rust-lang:master Apr 15, 2015
@alexcrichton alexcrichton deleted the remove-deprecated branch April 15, 2015 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants