Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the rt::unwind line argument type from usize to u32. #24323

Merged
merged 1 commit into from
Apr 13, 2015

Conversation

rprichard
Copy link
Contributor

There are syntax extensions that call std::rt::begin_unwind passing it a usize. I updated the syntax extension to instead pass u32, but for bootstrapping reasons, I needed to create a #[cfg(stage0)] version of std::rt::begin_unwind and therefore also panic!.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rprichard
Copy link
Contributor Author

I suppose I should provide a little more context. The type of line! and column! was changed from usize to u32 in PR #21769. The type of the line value has already been updated in the core::panicking functions, but not in the std::rt::unwind functions.

@alexcrichton
Copy link
Member

@bors: r+ ef25b7d

Thanks!

@alexcrichton
Copy link
Member

@bors: r+ ef25b7d

@bors
Copy link
Contributor

bors commented Apr 13, 2015

⌛ Testing commit ef25b7d with merge 49798c5...

bors added a commit that referenced this pull request Apr 13, 2015
There are syntax extensions that call `std::rt::begin_unwind` passing it a `usize`.  I updated the syntax extension to instead pass `u32`, but for bootstrapping reasons, I needed to create a `#[cfg(stage0)]` version of `std::rt::begin_unwind` and therefore also `panic!`.
@bors bors merged commit ef25b7d into rust-lang:master Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants