std: Remove final usage of fds from Windows #24426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
| let mut reader = libc::INVALID_HANDLE_VALUE; | ||
| let mut writer = libc::INVALID_HANDLE_VALUE; | ||
| try!(cvt(unsafe { | ||
| c::CreatePipe(&mut reader, &mut writer, 0 as *mut _, 1024) |
There was a problem hiding this comment.
Personally I'd just set the buffer size to 0 to use the OS default.
|
Implementation looks good to me. |
This commit removes the last remnants of file descriptors from the Windows implementation of `std::sys` by using `CreatePipe` to create anonymous pipes instead of the `pipe` shim provided in msvcrt.
alexcrichton
force-pushed
the
windows-pipes
branch
from
707647a to
5e07329
Compare
|
Oh happy days! Especially nice to see the drop changes. @bors: r+ |
|
📌 Commit 5e07329 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 15, 2015
This commit removes the last remnants of file descriptors from the Windows implementation of `std::sys` by using `CreatePipe` to create anonymous pipes instead of the `pipe` shim provided in msvcrt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the last remnants of file descriptors from the Windows
implementation of
std::sysby usingCreatePipeto create anonymous pipesinstead of the
pipeshim provided in msvcrt.