Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Don't succeed if valgrind isn't available. Fixes #18588 #24477

Closed
wants to merge 2 commits into from
Closed

configure: Don't succeed if valgrind isn't available. Fixes #18588 #24477

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb64c7b
configure: Don't succeed if valgrind isn't available. Fixes #18588
brson Apr 15, 2015
31856a5
Typo
brson Apr 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,15 @@ then
fi
fi

# By default the test suite *requires* valgrind. Detect it's absence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/it's/its/

if [ -z "$CFG_VALGRIND" ]
then
if [ ! -z "$CFG_ENABLE_VALGRIND" ] || [ -z "$CFG_DISABLE_VALGRIND_RPASS" ]
then
err "valgrind not found, but needed. consider adding --disable-valgrind-rpass"
fi
fi

step_msg "looking for target specific programs"

probe CFG_ADB adb
Expand Down