-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add long diagnostics for "bind by-ref and by-move" #24482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,6 +112,53 @@ reference when using guards or refactor the entire expression, perhaps by | |
putting the condition inside the body of the arm. | ||
"##, | ||
|
||
E0009: r##" | ||
In a pattern, all values that don't implement the `Copy` trait have to be bound | ||
the same way. The goal here is to avoid binding simultaneous by-move and by-ref. | ||
|
||
This limitation may be removed in a future version of Rust. | ||
|
||
Wrong example: | ||
|
||
``` | ||
struct X { x: (), } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Add code fences ("```") and some whitespace |
||
|
||
let x = Some((X { x: () }, X { x: () })); | ||
match x { | ||
Some((y, ref z)) => {}, | ||
None => panic!() | ||
} | ||
``` | ||
|
||
You have two solutions: | ||
1. Bind the pattern's values the same way: | ||
|
||
``` | ||
struct X { x: (), } | ||
|
||
let x = Some((X { x: () }, X { x: () })); | ||
match x { | ||
Some((ref y, ref z)) => {}, | ||
// or Some((y, z)) => {} | ||
None => panic!() | ||
} | ||
``` | ||
|
||
2. Implement the `Copy` trait for the X structure (however, please | ||
keep in mind that the first solution should be preferred!): | ||
|
||
``` | ||
#[derive(Clone, Copy)] | ||
struct X { x: (), } | ||
|
||
let x = Some((X { x: () }, X { x: () })); | ||
match x { | ||
Some((y, ref z)) => {}, | ||
None => panic!() | ||
} | ||
``` | ||
"##, | ||
|
||
E0152: r##" | ||
Lang items are already implemented in the standard library. Unless you are | ||
writing a free-standing application (e.g. a kernel), you do not need to provide | ||
|
@@ -308,7 +355,6 @@ a compile-time constant. | |
} | ||
|
||
register_diagnostics! { | ||
E0009, | ||
E0010, | ||
E0011, | ||
E0012, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a newline