Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link id for stackoverflow #24493

Closed
wants to merge 1 commit into from

Conversation

aethanyc
Copy link
Contributor

The document does not display properly if the link id contains a space.

The document does not display properly if the link id contains a space.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors; r+ rollup

@bors
Copy link
Contributor

bors commented Apr 16, 2015

📌 Commit 7d56fb2 has been approved by steveklabnik

@steveklabnik
Copy link
Member

TIL. Thanks!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 16, 2015
…steveklabnik

The document does not display properly if the link id contains a space.
bors added a commit that referenced this pull request Apr 16, 2015
bors added a commit that referenced this pull request Apr 17, 2015
bors added a commit that referenced this pull request Apr 17, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
…steveklabnik

 The document does not display properly if the link id contains a space.
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
…steveklabnik

 The document does not display properly if the link id contains a space.
@steveklabnik
Copy link
Member

This was merged in #24512 , sorry, I rebased and forgot that'd screw it up :(

@aethanyc aethanyc deleted the fix-stackoverflow-link branch April 18, 2015 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants