-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference tidying #24548
Reference tidying #24548
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ rollup |
📌 Commit a99a8b0 has been approved by |
❤️❤️❤️❤️❤️❤️❤️❤️👌👍 |
@@ -3888,7 +3883,7 @@ Box<i32>, y: Box<i32>)` declare one mutable variable `x` and one immutable | |||
variable `y`). | |||
|
|||
Methods that take either `self` or `Box<Self>` can optionally place them in a | |||
mutable slot by prefixing them with `mut` (similar to regular arguments): | |||
mutable variable by prefixing them with `mut` (similar to regular arguments): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think the original word "slot" might be more accurate.
If I have to change "slot" to something I would use "binding" in this case.
See #24149
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, binding is fine. Slot is just very old terminology, the only uses in this sense remaining are weird old corners of trans inside the compiler. In the docs it's a dead term, sticks out.
…labnik This just deletes some egregious lies and obsolete terminology -- all of which I originally wrote -- from the reference. I expect the reference itself will be deleted soon enough, but I found myself gritting teeth over these bits too much to let them into a 1.0 release.
This just deletes some egregious lies and obsolete terminology -- all of which I originally wrote -- from the reference. I expect the reference itself will be deleted soon enough, but I found myself gritting teeth over these bits too much to let them into a 1.0 release.