-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Correct code for operations on empty Vec
s
#24604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @gankro (rust_highfive has picked a reviewer for you, use r? to override) |
Does offsetting by |
So yes this change seems to be necesssary |
LGTM @bors r+ |
📌 Commit 17531a6 has been approved by |
⌛ Testing commit 17531a6 with merge 385e300... |
💔 Test failed - auto-linux-64-nopt-t |
There are many more changes needed in |
CC @Aatch on the above language question. |
☔ The latest upstream changes (presumably #24674) made this pull request unmergeable. Please resolve the merge conflicts. |
@pczarn ping |
Closing as inactive |
Corrected a few cases of using an invalid pointer
0x1
. Even taking an offset of 0 leads to undefined behavior.