Rollup of 10 pull requests #24637
Closed
Rollup of 10 pull requests #24637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code attempts to define the PRETTY_DEPS$(1)_H_$(3)_pretty-rpass-full variable, which does not work, because $(1) and $(3) are not inside a function. Moving it into a function helps, but we need the target library (TLIB), not the host library (HLIB). Moreover, there is a test (run-pass-fulldeps/compiler-calls.rs) that uses rustc_driver, which is not an indirect dependency of librustc or libsyntax. Listing all the dependencies will be hard to maintain, but there's a better way to do this... As with the rpass-full and cfail-full tests, add dependencies using the $$(CSREQ$(1)_T_$(2)_H_$(3)) variable, which includes the complete set of host and target crates, built for a particular stage, host, and target. Fixes rust-lang#22021
As far as I can tell, this conversion to integer to floating point does not need to happen and is beside the point
Now that we're not doing the guessing game, a lot of this is irrelevant.
Partially addresses rust-lang#24388
We want to talk about how to pattern match on structs, so let's bump it back one.
It's a trait implementation, so we need traits first.
It's a language feature, so it belongs here.
Let's talk about generics first, since we use traits to bound them in funtions. Partially addresses rust-lang#24325 Fixes rust-lang#24271
Without the `box` keyword, one of these two reasons is not correct, so let's just eliminate this section and elaborate on the reason for the legit use case inline. Fixes rust-lang#24511
Due to documenting `transmute`, addresses part of rust-lang#12905
The slice patterns example was nice, so let's put it with the other slice pattern feature gate documentation. Fixes rust-lang#24573
This required fixing the `pretty-rpass-full` tests to have the same `$$(CSREQ$(1)_T_$(2)_H_$(3))` dependencies as the `rpass-full` and `cfail-full` tests. It also required fixing the `run-make/simd-ffi` test to use unique names for its output files.
A bunch of chapters, fixes an issue or two as well. r? @alexcrichton
As far as I can tell, this conversion to integer to floating point does not need to happen and is beside the point
Fixes rust-lang#24173 These docs could all use examples, so for now, let's just remove the bad one, and when I go over this whole module I'll put in better ones.
Without the `box` keyword, one of these two reasons is not correct, so let's just eliminate this section and elaborate on the reason for the legit use case inline. Fixes rust-lang#24511
…richton Due to documenting `transmute`, addresses part of rust-lang#12905
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=100 |
|
📌 Commit fb57ba0 has been approved by |
|
⌛ Testing commit fb57ba0 with merge 064a677... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry force |
|
⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-64-nopt-t are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-opt... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check#24537, More TRPl editing #24571, Remove feature gated examples from the reference #24577, Simplify alloc::arc::Arc example in doc-comment #24625, Make iterator struct docs more consistent. #24627, remove bad example from PartialEq docs #24628, Clean up Box documentation. #24629, Fix small typo in TRPL intro #24630, TRPL: casting #24632