Tidy up some Android tests #24681

tamird · 2015-04-22T05:23:51Z

There are still quite a few ignored Android tests kicking around, most of which were added in 445faca, which has a pretty unfortunate commit message.

r? @alexcrichton

tamird · 2015-04-22T05:25:13Z

A try here would be great

huonw · 2015-04-22T05:41:20Z

@bors try

@alexcrichton

There are still quite a few ignored Android tests kicking around, most of which were added in 445faca, which has a pretty unfortunate commit message. r? @alexcrichton

bors · 2015-04-22T05:41:23Z

⌛ Trying commit 1af79c6 with merge 43dd852...

bors · 2015-04-22T08:12:19Z

☀️ Test successful - try-bsd, try-linux, try-mac, try-win-32, try-win-64

tamird · 2015-04-22T14:07:36Z

try doesn't test on android :(

alexcrichton · 2015-04-22T15:28:05Z

Eh we've got a pretty small queue right now, let's just send this to bors and see what happens!

@bors: r+ 3580084

bors · 2015-04-22T17:32:39Z

⌛ Testing commit 3580084 with merge df7b096...

bors · 2015-04-22T18:48:30Z

💔 Test failed - auto-mac-64-opt

tamird · 2015-04-22T18:56:44Z

@alexcrichton had some line number drift :(

Give this another go?

alexcrichton · 2015-04-22T19:00:09Z

@bors: r+ ac14abb

bors · 2015-04-22T20:54:32Z

⌛ Testing commit ac14abb with merge 45bc6ce...

bors · 2015-04-22T22:10:22Z

💔 Test failed - auto-linux-64-x-android-t

tamird · 2015-04-22T22:11:48Z

src/test/run-pass/linkage-visibility.rs

@@ -9,7 +9,6 @@
 // except according to those terms.

 // aux-build:linkage-visibility.rs
-// ignore-android: FIXME(#10379)


well this one is still broken

tamird · 2015-04-22T22:43:32Z

@alexcrichton once more?

alexcrichton · 2015-04-22T23:00:10Z

@bors: r+ 5a68169

bors · 2015-04-22T23:22:45Z

⌛ Testing commit 5a68169 with merge 39b85d0...

bors · 2015-04-22T23:25:31Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2015-04-23T01:33:52Z

⌛ Testing commit 5a68169 with merge ba5aa47...

bors · 2015-04-23T02:45:05Z

💔 Test failed - auto-linux-64-opt

tamird · 2015-04-23T02:46:53Z

@alexcrichton can you hit the retry? this failed on net::tcp::tests::fast_rebind which looks spurious

alexcrichton · 2015-04-23T15:36:51Z

@bors: retry

@alexcrichton

There are still quite a few ignored Android tests kicking around, most of which were added in 445faca, which has a pretty unfortunate commit message. r? @alexcrichton

bors · 2015-04-25T08:45:38Z

💔 Test failed - auto-linux-64-opt

alexcrichton · 2015-04-25T17:36:54Z

@bors: retry

On Sat, Apr 25, 2015 at 1:45 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-opt
http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4656

—
Reply to this email directly or view it on GitHub
#24681 (comment).

bors · 2015-04-25T19:02:58Z

⌛ Testing commit 7f87424 with merge ab3204f...

bors · 2015-04-25T20:51:39Z

💔 Test failed - auto-linux-64-x-android-t

tamird · 2015-04-25T21:14:01Z

shootout-k-nucleotide-pipes still failed :(

@alexcrichton another go?

alexcrichton · 2015-04-27T06:44:18Z

@bors: r+ fb5f18b

@alexcrichton

There are still quite a few ignored Android tests kicking around, most of which were added in 445faca, which has a pretty unfortunate commit message. r? @alexcrichton

bors · 2015-04-27T09:00:51Z

⌛ Testing commit fb5f18b with merge ca34758...

bors · 2015-04-27T10:49:10Z

💔 Test failed - auto-linux-64-x-android-t

alexcrichton · 2015-04-27T16:59:05Z

@tamird at this point I think it may be best to start setting up an Android installation locally and testing this out there, bouncing on bors may be starting to take up some time :(

alexcrichton · 2015-04-29T00:32:16Z

So I've run some more of these tests locally and it looks like basically everything that was unignored unfortunately wasn't fixed in the meantime. Perhaps the stylistics tweaks could just be merged?

tamird · 2015-04-29T00:45:28Z

D'oh. #10381 should be reopened, or should a new issue be opened for those? What was the failure?

I'm surprised #9116 failed as well.

By the way, how does one run these locally? I'd be happy to dig deeper in a subsequent PR (I'll rebase this one to keep the stylistics shortly).

tamird · 2015-04-29T00:52:12Z

@alexcrichton updated.

alexcrichton · 2015-04-29T00:56:54Z

@bors: r+ bd5afb4

To run these locally you'll need to install the NDK and then configure rustc accordingly (I normally just copy the ./configure line of the bots). You'll then run an emulator in the background which compiletest connects to and sends binaries to. Here's the old wiki page

@alexcrichton

There are still quite a few ignored Android tests kicking around, most of which were added in 445faca, which has a pretty unfortunate commit message. r? @alexcrichton

bors · 2015-04-29T04:09:46Z

⌛ Testing commit bd5afb4 with merge d4cedea...

bors · 2015-04-29T06:03:41Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

rust-highfive assigned alexcrichton Apr 22, 2015

tamird force-pushed the unignore-android branch from 1af79c6 to 3580084 Compare April 22, 2015 14:07

tamird force-pushed the unignore-android branch from 3580084 to ac14abb Compare April 22, 2015 18:56

tamird reviewed Apr 22, 2015
View reviewed changes

tamird force-pushed the unignore-android branch from ac14abb to 5a68169 Compare April 22, 2015 22:43

tamird force-pushed the unignore-android branch from 7f87424 to fb5f18b Compare April 25, 2015 21:12

tamird added 3 commits April 28, 2015 17:49

rust-lang#10393 & rust-lang#13206: Warnings

41ff911

Reference the correct issue and clarify failure

9768447

rust-lang#10381: Warnings

54de911

tamird force-pushed the unignore-android branch from fb5f18b to 8a6b7af Compare April 29, 2015 00:52

tamird added 2 commits April 28, 2015 17:52

rust-lang#10356: Warnings

c6364ab

Reference the correct issue

bd5afb4

tamird force-pushed the unignore-android branch from 8a6b7af to bd5afb4 Compare April 29, 2015 00:52

tamird changed the title ~~Re-enable some Android tests~~ Tidy up some Android tests Apr 29, 2015

bors merged commit bd5afb4 into rust-lang:master Apr 29, 2015

tamird deleted the unignore-android branch April 29, 2015 14:22

Tidy up some Android tests #24681

Tidy up some Android tests #24681

Conversation

tamird commented Apr 22, 2015

tamird commented Apr 22, 2015

huonw commented Apr 22, 2015

bors commented Apr 22, 2015

bors commented Apr 22, 2015

tamird commented Apr 22, 2015

alexcrichton commented Apr 22, 2015

bors commented Apr 22, 2015

bors commented Apr 22, 2015

tamird commented Apr 22, 2015

alexcrichton commented Apr 22, 2015

bors commented Apr 22, 2015

bors commented Apr 22, 2015

tamird Apr 22, 2015

Choose a reason for hiding this comment

tamird commented Apr 22, 2015

alexcrichton commented Apr 22, 2015

bors commented Apr 22, 2015

bors commented Apr 22, 2015

bors commented Apr 23, 2015

bors commented Apr 23, 2015

tamird commented Apr 23, 2015

alexcrichton commented Apr 23, 2015

bors commented Apr 25, 2015

alexcrichton commented Apr 25, 2015

bors commented Apr 25, 2015

bors commented Apr 25, 2015

tamird commented Apr 25, 2015

alexcrichton commented Apr 27, 2015

bors commented Apr 27, 2015

bors commented Apr 27, 2015

alexcrichton commented Apr 27, 2015

alexcrichton commented Apr 29, 2015

tamird commented Apr 29, 2015

tamird commented Apr 29, 2015

alexcrichton commented Apr 29, 2015

bors commented Apr 29, 2015

bors commented Apr 29, 2015