Indent code past the widest line number #25037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| assert!(display_line_infos.len() > 0); | ||
| let mut max_line_num = display_line_infos[display_line_infos.len() - 1].line_index + 1; | ||
| let mut digits = 0; | ||
| while max_line_num > 0 { max_line_num /= 10; digits += 1; } |
There was a problem hiding this comment.
nit this would better to be split across multiple lines
|
It would be nice to have a test for this. Could you add a unit test for the function itself maybe? If that is possible then I guess we can land without a test. Code looks good though. |
|
☔ The latest upstream changes (presumably #26190) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing in favour of #26540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11715
I don't know what's the best way to test this...